Android build support - #43
Merged
Merged
Conversation
Doru991
requested review from
OllieOlafsson,
ValentinNimigean,
catyuzu23 and
kickhead13
March 6, 2026 22:34
kickhead13
requested changes
Mar 6, 2026
Comment on lines
+14
to
+15
| #[cfg(debug_assertions)] | ||
| println!("write: {}", path.display()); |
Member
There was a problem hiding this comment.
Why not use the logger here? (from src/prelude.rs)
Contributor
Author
There was a problem hiding this comment.
Forgot about it, done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some small modifications in order to make the app capable of building and running on Android with the same codebase. The main changes are:
AI assistance: Troubleshooting Android build and execution issues; Model used: Claude Opus 4.6 on Claude Code.